Spearhead/joyent-portal
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

remove value validation in <RadioGroup>

Browse Source 
it's redundant since we already require it in <Radio> propTypes
This commit is contained in:
Sérgio Ramos 2016-10-28 17:01:12 +01:00
parent 033093033a
commit b3ee3b53ce
1 changed files with 1 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
ui/src/components/radio-group/index.js
View File

@ -8,7 +8,6 @@
const first = require('lodash.first');
const isUndefined = require('lodash.isundefined');
const get = require('lodash.get');
const invariant = require('invariant');
const Item = require('./item');
const find = require('lodash.find');
const classNames = require('classnames');
@ -27,11 +26,8 @@ const RadioGroup = React.createClass({
getInitialState: function() {
return this.getState(this.props);
},
componentWillMount: function() {
return this.checkValues(this.props);
},
componentWillReceiveProps: function(nextProps) {
return this.setState(this.checkValues(nextProps));
return this.setState(nextProps);
},
getState: function(props) {
const _children = React.Children.toArray(props.children).filter((child) => {
@ -65,13 +61,6 @@ const RadioGroup = React.createClass({
checked
};
},
checkValues: function(props) {
invariant(React.Children.toArray(props.children).every((child) => {
return (child.type.name !== 'Radio') ? true : !!child.props.value;
}), 'All <Radio> childs of <RadioGroup> must have a value property');
return props;
},
handleChange: function(key) {
return (ev) => {
const {