joyent/node-triton#213 commands fail unhelpfully when cliSetupTritonApi returns error

Reviewed by: Trent Mick <trent.mick@joyent.com>
Reviewed by: Sam Gwydir <sam.gwydir@joyent.com>
Approved by: Trent Mick <trent.mick@joyent.com>

CHANGES.md

@@ -9,6 +9,9 @@ Known issues:
 
 - [joyent/node-triton#193] Fix possible CLI crash with `triton ssh ...` if the
   instance's image doesn't have any tags.
+- [joyent/node-triton#213] commands fail unhelpfully when `cliSetupTritonApi`
+  returns error (this includes e.g. supplying an incorrect key fingerprint,
+  which no longer results in a cryptic stack trace and crash)
 
 ## 5.2.0
 

lib/do_account/do_get.js

@@ -25,6 +25,7 @@ function do_get(subcmd, opts, args, callback) {
     common.cliSetupTritonApi({cli: this.top}, function onSetup(setupErr) {
         if (setupErr) {
             callback(setupErr);
+            return;
         }
         tritonapi.cloudapi.getAccount(function (err, account) {
             if (err) {

lib/do_datacenters.js

@@ -36,6 +36,7 @@ function do_datacenters(subcmd, opts, args, callback) {
     common.cliSetupTritonApi({cli: this}, function onSetup(setupErr) {
         if (setupErr) {
             callback(setupErr);
+            return;
         }
         tritonapi.cloudapi.listDatacenters(function (err, datacenters) {
             if (err) {

lib/do_fwrule/do_create.js

@@ -49,6 +49,7 @@ function do_create(subcmd, opts, args, cb) {
     common.cliSetupTritonApi({cli: this.top}, function onSetup(setupErr) {
         if (setupErr) {
             cb(setupErr);
+            return;
         }
         tritonapi.cloudapi.createFirewallRule(
             createOpts, function (err, fwrule) {

lib/do_fwrule/do_disable.js

@@ -34,6 +34,7 @@ function do_disable(subcmd, opts, args, cb) {
     common.cliSetupTritonApi({cli: this.top}, function onSetup(setupErr) {
         if (setupErr) {
             cb(setupErr);
+            return;
         }
         vasync.forEachParallel({
             inputs: args,

lib/do_fwrule/do_enable.js

@@ -34,6 +34,7 @@ function do_enable(subcmd, opts, args, cb) {
     common.cliSetupTritonApi({cli: this.top}, function onSetup(setupErr) {
         if (setupErr) {
             cb(setupErr);
+            return;
         }
         vasync.forEachParallel({
             inputs: args,

lib/do_fwrule/do_get.js

@@ -38,6 +38,7 @@ function do_get(subcmd, opts, args, cb) {
     common.cliSetupTritonApi({cli: this.top}, function onSetup(setupErr) {
         if (setupErr) {
             cb(setupErr);
+            return;
         }
         tritonapi.getFirewallRule(id, function onRule(err, fwrule) {
             if (err) {

lib/do_fwrule/do_instances.js

@@ -57,6 +57,7 @@ function do_instances(subcmd, opts, args, cb) {
     common.cliSetupTritonApi({cli: this.top}, function onSetup(setupErr) {
         if (setupErr) {
             cb(setupErr);
+            return;
         }
         vasync.parallel({funcs: [
             function getTheImages(next) {

lib/do_fwrule/do_list.js

@@ -39,6 +39,7 @@ function do_list(subcmd, opts, args, cb) {
     common.cliSetupTritonApi({cli: this.top}, function onSetup(setupErr) {
         if (setupErr) {
             cb(setupErr);
+            return;
         }
         tritonapi.cloudapi.listFirewallRules({}, function onRules(err, rules) {
             if (err) {

lib/do_image/do_get.js

@@ -29,6 +29,7 @@ function do_get(subcmd, opts, args, callback) {
     common.cliSetupTritonApi({cli: this.top}, function onSetup(setupErr) {
         if (setupErr) {
             callback(setupErr);
+            return;
         }
         tritonapi.getImage(args[0], function onRes(err, img) {
             if (err) {

lib/do_image/do_list.js

@@ -67,6 +67,7 @@ function do_list(subcmd, opts, args, callback) {
     common.cliSetupTritonApi({cli: this.top}, function onSetup(setupErr) {
         if (setupErr) {
             callback(setupErr);
+            return;
         }
         tritonapi.listImages(listOpts, function onRes(err, imgs, res) {
             if (err) {

lib/do_info.js

@@ -33,6 +33,7 @@ function do_info(subcmd, opts, args, callback) {
     common.cliSetupTritonApi({cli: this}, function onSetup(setupErr) {
         if (setupErr) {
             callback(setupErr);
+            return;
         }
         tritonapi.cloudapi.getAccount(cb.bind('account'));    i++;
         tritonapi.cloudapi.listMachines(cb.bind('machines')); i++;

lib/do_instance/do_audit.js

@@ -53,6 +53,10 @@ function do_audit(subcmd, opts, args, cb) {
     var tritonapi = this.top.tritonapi;
 
     common.cliSetupTritonApi({cli: this.top}, function onSetup(setupErr) {
+        if (setupErr) {
+            cb(setupErr);
+            return;
+        }
         if (common.isUUID(arg)) {
             uuid = arg;
             go1();

lib/do_instance/do_disable_firewall.js

@@ -54,6 +54,7 @@ function do_disable_firewall(subcmd, opts, args, cb) {
     common.cliSetupTritonApi({cli: this.top}, function onSetup(setupErr) {
         if (setupErr) {
             cb(setupErr);
+            return;
         }
         vasync.forEachParallel({
             inputs: args,

lib/do_instance/do_enable_firewall.js

@@ -54,6 +54,7 @@ function do_enable_firewall(subcmd, opts, args, cb) {
     common.cliSetupTritonApi({cli: this.top}, function onSetup(setupErr) {
         if (setupErr) {
             cb(setupErr);
+            return;
         }
         vasync.forEachParallel({
             inputs: args,

lib/do_instance/do_fwrule/do_list.js

@@ -44,6 +44,7 @@ function do_list(subcmd, opts, args, cb) {
     common.cliSetupTritonApi({cli: this.top}, function onSetup(setupErr) {
         if (setupErr) {
             cb(setupErr);
+            return;
         }
         tritonapi.listInstanceFirewallRules({
             id: id

lib/do_instance/do_get.js

@@ -23,6 +23,7 @@ function do_get(subcmd, opts, args, cb) {
     common.cliSetupTritonApi({cli: this.top}, function onSetup(setupErr) {
         if (setupErr) {
             cb(setupErr);
+            return;
         }
         tritonapi.getInstance(args[0], function (err, inst) {
             if (inst) {

lib/do_instance/do_ip.js

@@ -33,6 +33,7 @@ function do_ip(subcmd, opts, args, cb) {
     common.cliSetupTritonApi({cli: this.top}, function onSetup(setupErr) {
         if (setupErr) {
             cb(setupErr);
+            return;
         }
         cli.tritonapi.getInstance(args[0], function (err, inst) {
             if (err) {

lib/do_instance/do_list.js

@@ -77,6 +77,7 @@ function do_list(subcmd, opts, args, callback) {
     common.cliSetupTritonApi({cli: this.top}, function onSetup(setupErr) {
         if (setupErr) {
             callback(setupErr);
+            return;
         }
         vasync.parallel({funcs: [
             function getTheImages(next) {

lib/do_instance/do_reboot.js

@@ -30,6 +30,7 @@ function do_reboot(subcmd, opts, args, cb) {
     common.cliSetupTritonApi({cli: this.top}, function onSetup(setupErr) {
         if (setupErr) {
             cb(setupErr);
+            return;
         }
 
         var rebootErrs = [];

lib/do_instance/do_rename.js

@@ -27,6 +27,7 @@ function do_rename(subcmd, opts, args, callback) {
     common.cliSetupTritonApi({cli: this.top}, function onSetup(setupErr) {
         if (setupErr) {
             callback(setupErr);
+            return;
         }
 
         tritonapi.renameInstance({

lib/do_instance/do_resize.js

@@ -27,6 +27,7 @@ function do_resize(subcmd, opts, args, callback) {
     common.cliSetupTritonApi({cli: this.top}, function onSetup(setupErr) {
         if (setupErr) {
             callback(setupErr);
+            return;
         }
 
         tritonapi.resizeInstance({

lib/do_instance/do_snapshot/do_get.js

@@ -39,6 +39,7 @@ function do_get(subcmd, opts, args, cb) {
     common.cliSetupTritonApi({cli: this.top}, function onSetup(setupErr) {
         if (setupErr) {
             cb(setupErr);
+            return;
         }
         cli.tritonapi.getInstanceSnapshot({
             id: id,

lib/do_instance/do_snapshot/do_list.js

@@ -43,6 +43,7 @@ function do_list(subcmd, opts, args, cb) {
     common.cliSetupTritonApi({cli: this.top}, function onSetup(setupErr) {
         if (setupErr) {
             cb(setupErr);
+            return;
         }
         cli.tritonapi.listInstanceSnapshots({
             id: machineId

lib/do_instance/do_tag/do_delete.js

@@ -33,6 +33,7 @@ function do_delete(subcmd, opts, args, cb) {
     common.cliSetupTritonApi({cli: this.top}, function onSetup(setupErr) {
         if (setupErr) {
             cb(setupErr);
+            return;
         }
         if (opts.all) {
             self.top.tritonapi.deleteAllInstanceTags({

lib/do_instance/do_tag/do_get.js

@@ -27,6 +27,7 @@ function do_get(subcmd, opts, args, cb) {
     common.cliSetupTritonApi({cli: this.top}, function onSetup(setupErr) {
         if (setupErr) {
             cb(setupErr);
+            return;
         }
         self.top.tritonapi.getInstanceTag({
             id: args[0],

lib/do_instance/do_tag/do_list.js

@@ -26,6 +26,7 @@ function do_list(subcmd, opts, args, cb) {
     common.cliSetupTritonApi({cli: this.top}, function onSetup(setupErr) {
         if (setupErr) {
             cb(setupErr);
+            return;
         }
         self.top.tritonapi.listInstanceTags(
             {id: args[0]}, function (err, tags) {

lib/do_instance/gen_do_ACTION.js

@@ -112,6 +112,7 @@ function _doTheAction(action, subcmd, opts, args, callback) {
     common.cliSetupTritonApi({cli: this.top}, function onSetup(setupErr) {
         if (setupErr) {
             callback(setupErr);
+            return;
         }
         _doOnEachInstance(self, action, command, state, args, opts, callback);
     });

lib/do_key/do_get.js

@@ -38,6 +38,7 @@ function do_get(subcmd, opts, args, cb) {
     common.cliSetupTritonApi({cli: this.top}, function onSetup(setupErr) {
         if (setupErr) {
             cb(setupErr);
+            return;
         }
         cli.tritonapi.cloudapi.getKey({
             // Currently `cloudapi.getUserKey` isn't picky about the

lib/do_key/do_list.js

@@ -40,6 +40,7 @@ function do_list(subcmd, opts, args, cb) {
     common.cliSetupTritonApi({cli: this.top}, function onSetup(setupErr) {
         if (setupErr) {
             cb(setupErr);
+            return;
         }
         cli.tritonapi.cloudapi.listKeys({}, function onKeys(err, keys) {
             if (err) {

lib/do_network/do_get.js

@@ -30,6 +30,7 @@ function do_get(subcmd, opts, args, cb) {
     common.cliSetupTritonApi({cli: this.top}, function onSetup(setupErr) {
         if (setupErr) {
             cb(setupErr);
+            return;
         }
         tritonapi.getNetwork(args[0], function (err, net) {
             if (err) {

lib/do_package/do_get.js

@@ -29,6 +29,7 @@ function do_get(subcmd, opts, args, callback) {
     common.cliSetupTritonApi({cli: this.top}, function onSetup(setupErr) {
         if (setupErr) {
             callback(setupErr);
+            return;
         }
         tritonapi.getPackage(args[0], function onRes(err, pkg) {
             if (err) {

lib/do_services.js

@@ -36,6 +36,7 @@ function do_services(subcmd, opts, args, callback) {
     common.cliSetupTritonApi({cli: this}, function onSetup(setupErr) {
         if (setupErr) {
             callback(setupErr);
+            return;
         }
         tritonapi.cloudapi.listServices(function (err, services) {
             if (err) {