3824623404
- Don't need confirmation/--force for undoable commands - Drop duration from output message after wait. I don't feel the time for this should ever be long enough that the number is interesting enough to get top billing. - If "shouldn't get here", then it should be an assert. - Use '_' instead of '__' for unused options. - Drop the res.instId hack. Instead use a partial faux instance in place where other endpoints return a machine object. - Add 'tritoninstance' bash completion. - Group together with 'fwrules' in 'triton inst' help output.
103 lines
2.5 KiB
JavaScript
103 lines
2.5 KiB
JavaScript
/*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*/
|
|
|
|
/*
|
|
* Copyright 2016 Joyent, Inc.
|
|
*
|
|
* `triton instance enable-firewall ...`
|
|
*/
|
|
|
|
var assert = require('assert-plus');
|
|
var format = require('util').format;
|
|
var vasync = require('vasync');
|
|
|
|
var errors = require('../errors');
|
|
|
|
|
|
function do_enable_firewall(subcmd, opts, args, cb) {
|
|
assert.func(cb, 'cb');
|
|
|
|
if (opts.help) {
|
|
this.do_help('help', {}, [subcmd], cb);
|
|
return;
|
|
}
|
|
|
|
if (args.length === 0) {
|
|
cb(new errors.UsageError('Missing <inst> argument(s)'));
|
|
return;
|
|
}
|
|
|
|
var cli = this.top;
|
|
|
|
function wait(name, id, next) {
|
|
cli.tritonapi.cloudapi.waitForMachineFirewallEnabled({
|
|
id: id,
|
|
state: true
|
|
}, function (err, inst) {
|
|
if (err) {
|
|
next(err);
|
|
return;
|
|
}
|
|
assert.ok(inst.firewall_enabled, format(
|
|
'inst %s firewall_enabled not in expected state after '
|
|
+ 'waitForMachineFirewallEnabled', id));
|
|
|
|
console.log('Enabled firewall for instance "%s"', name);
|
|
next();
|
|
});
|
|
}
|
|
|
|
vasync.forEachParallel({
|
|
inputs: args,
|
|
func: function enableOne(name, nextInst) {
|
|
cli.tritonapi.enableInstanceFirewall({
|
|
id: name
|
|
}, function (err, fauxInst) {
|
|
if (err) {
|
|
nextInst(err);
|
|
return;
|
|
}
|
|
|
|
console.log('Enabling firewall for instance "%s"', name);
|
|
|
|
if (opts.wait) {
|
|
wait(name, fauxInst.id, nextInst);
|
|
} else {
|
|
nextInst();
|
|
}
|
|
});
|
|
}
|
|
}, function (err) {
|
|
cb(err);
|
|
});
|
|
}
|
|
|
|
|
|
do_enable_firewall.options = [
|
|
{
|
|
names: ['help', 'h'],
|
|
type: 'bool',
|
|
help: 'Show this help.'
|
|
},
|
|
{
|
|
names: ['wait', 'w'],
|
|
type: 'bool',
|
|
help: 'Wait for the firewall to be enabled.'
|
|
}
|
|
];
|
|
do_enable_firewall.help = [
|
|
'Enable the firewall of one or more instances.',
|
|
'',
|
|
'Usage:',
|
|
' {{name}} enable-firewall [<options>] <inst> [<inst>...]',
|
|
'',
|
|
'{{options}}'
|
|
].join('\n');
|
|
|
|
do_enable_firewall.completionArgtypes = ['tritoninstance'];
|
|
|
|
module.exports = do_enable_firewall;
|