mpana/copilot
1
0
Fork 0
mirror of https://github.com/yldio/copilot.git synced 2024-11-28 06:00:06 +02:00
Code Issues Releases Wiki Activity

fix: handle empty history when deleting dg (#6)

Browse Source
This commit is contained in:
Sérgio Ramos 2017-09-18 21:49:10 +01:00 committed by Wyatt Preul
parent 37f2201923
commit ac2eab6cfe
2 changed files with 23 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/cp-frontend/src/graphql/DeploymentGroupDeleteMutation.gql
View File

@ -1,7 +1,5 @@
#import "./DeploymentGroupInfo.gql"
mutation DeleteDeploymentGroup($id: ID!) { mutation DeleteDeploymentGroup($id: ID!) {
deleteDeploymentGroup(id: $id) { deleteDeploymentGroup(id: $id) {
...DeploymentGroupInfo id
} }
} }

24
packages/portal-api/lib/data/index.js
View File

@ -466,6 +466,10 @@ class Data extends EventEmitter {
return cb(err); return cb(err);
} }
if (!deploymentGroup) {
return cb(null);
}
cb(null, Transform.fromDeploymentGroup(this._getDeploymentGroupFns(deploymentGroup))); cb(null, Transform.fromDeploymentGroup(this._getDeploymentGroupFns(deploymentGroup)));
}); });
} }
@ -545,7 +549,9 @@ class Data extends EventEmitter {
}, next); }, next);
} }
] ]
}, cb); }, (err) => {
cb(err, res.dg);
});
}; };
VAsync.parallel({ VAsync.parallel({
@ -695,7 +701,21 @@ class Data extends EventEmitter {
return finish(err); return finish(err);
} }
this._db.versions.get(deploymentGroup.history, finish); if (!deploymentGroup) {
return finish(null, []);
}
deploymentGroup.history({}, (err, history) => {
if (err) {
return finish(err);
}
if (!history.length) {
return finish(null, []);
}
this._db.versions.get(deploymentGroup.history.map(({ id }) => { return { id }; }), finish);
});
}); });
}); });
} }